InvisibleProgrammer commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1343778169
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -146,7 +146,7 @@ private void
testRebalanceCompactionWithParallelDeleteAsSecond(boolean optimisti
}
aborted = true;
Assert.assertEquals(e.getCause().getClass(), LockException.class);
- Assert.assertEquals(e.getCauseMessage(), "Transaction manager has
aborted the transaction txnid:21. Reason: Aborting [txnid:21,24] due to a
write conflict on default/rebalance_test committed by [txnid:20,24] d/u");
+ Assert.assertEquals( "Transaction manager has aborted the transaction
txnid:21. Reason: Aborting [txnid:21,24] due to a write conflict on
default/rebalance_test committed by [txnid:20,24] d/u", e.getCauseMessage());
Review Comment:
I like that you changed the order of the parameters as the first parameter
is the expected. However, now it bugs my mind that the other assertion in the
exact previous line still has the wrong order of parameters. Could you please
change that as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
