InvisibleProgrammer commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1343785741
##########
ql/src/test/results/clientpositive/tez/orc_merge12.q.out:
##########
@@ -144,7 +144,7 @@ PREHOOK: Input: default@alltypesorc3xcols
PREHOOK: Output: hdfs://### HDFS PATH ###
-- BEGIN ORC FILE DUMP --
Structure for hdfs://### HDFS PATH ###
-File Version: 0.12 with ORC_14 by ORC Java 1.8.3
+File Version:#Masked#
Review Comment:
TBH, that is the part that I would keep.
##########
ql/src/test/queries/clientpositive/row__id.q:
##########
@@ -1,6 +1,8 @@
+--! qt:replace:/(.+)(Data size: \d+)(.+)/$1#Masked#$3/
-- tid is flaky when compute column stats
set hive.stats.column.autogather=false;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+set hive.support.concurrency=true;
Review Comment:
It looks like a significant change in the test behaviour. Why is the change?
##########
ql/src/test/results/clientpositive/beeline/materialized_view_create_rewrite.q.out:
##########
@@ -63,7 +63,7 @@ numFiles 1
numFilesErasureCoded 0
numRows 2
rawDataSize 408
-totalSize 474
+totalSize #Masked#
Review Comment:
I love that is masked out. The PR at the next upgrade will contain half of
those files.
##########
standalone-metastore/pom.xml:
##########
@@ -89,7 +89,7 @@
<libthrift.version>0.16.0</libthrift.version>
<log4j2.version>2.18.0</log4j2.version>
<mockito-core.version>3.3.3</mockito-core.version>
- <orc.version>1.8.3</orc.version>
+ <orc.version>1.8.5</orc.version>
Review Comment:
I wonder, do we need to be able to define a different orc.version at the
standalone-metastore than in the root pom.xml?
Can we just use the version info from the root pom.xml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
