aturoczy commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1343796338
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java:
##########
@@ -398,7 +398,7 @@ public void testStatsAfterCompactionPartTbl() throws
Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"2", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"2", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"1396", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"1395", parameters.get("totalSize"));
Review Comment:
Are you sure that these size changes are relevant? Number of rows, or files
are ok. But the total size just did not give me any information. I think it
should be removed with the PR. It is just too many works for an Assert that is
constantly change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
