abstractdog commented on code in PR #4758:
URL: https://github.com/apache/hive/pull/4758#discussion_r1345441515
##########
common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java:
##########
@@ -95,6 +95,9 @@ public void testConfProperties() throws Exception {
// Test HiveConf property variable substitution in hive-site.xml
checkHiveConf("test.var.hiveconf.property",
ConfVars.DEFAULTPARTITIONNAME.getDefaultValue());
+
+ // Test if LLAP_LRFU_HOTBUFFERS_PERCENTAGE is defined in HiveConf
+
Assert.assertTrue(HiveConf.getLlapDaemonConfVars().contains(ConfVars.LLAP_LRFU_HOTBUFFERS_PERCENTAGE.varname));
Review Comment:
I see, my point is that when some LLAP cache related patches were backported
to downstream hive versions, there was a NoSuchFieldError and I'm wondering if
we can make a future-proof test...like: if something is added to a collection,
it should be added to / defined somewhere else
maybe it's silly but what about looping on ConfVars and check if name starts
with "LLAP_"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
