dengzhhu653 commented on code in PR #4726:
URL: https://github.com/apache/hive/pull/4726#discussion_r1364749729
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java:
##########
@@ -266,7 +271,9 @@ private void
assertCorrectPartitionValuesResponse(List<List<String>> testValues,
}
}
+ protected void assertPartitionsHaveCorrectParams(List<Partition> partitions)
{
Review Comment:
The check for partition params happens here:
https://github.com/apache/hive/blob/84583f6fa1c779908852c49510c03495534f2e03/ql/src/test/org/apache/hadoop/hive/metastore/TestListPartitionsWithXIncludeParams.java#L124-L133
The `TestListPartitionsWithXIncludeParams` is a child class of the
`TestListPartitions`, so it will overwrite this method. When runing
`TestListPartitionsWithXIncludeParams`, it will also check the partition params
of the tests in `TestListPartitions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
