saihemanth-cloudera commented on code in PR #4726:
URL: https://github.com/apache/hive/pull/4726#discussion_r1373912422


##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjectionAndFilterSpecs.java:
##########
@@ -229,8 +229,12 @@ public void testPartitionProjectionEmptySpec() throws 
Throwable {
       Assert.assertEquals(origPartition.getLastAccessTime(), 
retPartition.getLastAccessTime());
       Assert.assertEquals(origPartition.getSd().getLocation(),
           sharedSD.getLocation() + retPartition.getRelativePath());
-      validateMap(origPartition.getParameters(), retPartition.getParameters());
-      validateList(origPartition.getValues(), retPartition.getValues());

Review Comment:
   Were these intended changes? Why are we not validating the latest values 
with original values? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to