dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364754561
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ########## @@ -4129,6 +4129,8 @@ public List<Partition> getPartitions(Table tbl) throws HiveException { GetPartitionsPsWithAuthResponse res = getMSC().listPartitionsWithAuthInfoRequest(req); tParts = res.getPartitions(); + } catch (NoSuchObjectException nsoe) { + return Lists.newArrayList(); Review Comment: There are some cases in `Hive` throws empty result in case of `NoSuchObjectException`, for example: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3696 https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L4058 The `TestHiveMetaStoreClientApiArgumentsChecker` tests the case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org