dengzhhu653 commented on code in PR #4726:
URL: https://github.com/apache/hive/pull/4726#discussion_r1373991792
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjectionAndFilterSpecs.java:
##########
@@ -229,8 +229,12 @@ public void testPartitionProjectionEmptySpec() throws
Throwable {
Assert.assertEquals(origPartition.getLastAccessTime(),
retPartition.getLastAccessTime());
Assert.assertEquals(origPartition.getSd().getLocation(),
sharedSD.getLocation() + retPartition.getRelativePath());
- validateMap(origPartition.getParameters(), retPartition.getParameters());
- validateList(origPartition.getValues(), retPartition.getValues());
Review Comment:
yes, cause we set the exclude key in this test case:
https://github.com/apache/hive/blob/c3fa8a3da5e2e22f58f06356cb90232060404287/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjectionAndFilterSpecs.java#L204
Before the fix, we fallback to regular getPartitions as the project fields
are empty, so the exclude key doesn't take effect:
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L4776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
