dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1373993534
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java: ########## @@ -906,23 +908,22 @@ int getNumPartitionsByPs(String catName, String dbName, String tblName, List<Str */ default List<Partition> getPartitionsByNames(String catName, String dbName, String tblName, Review Comment: There are many callers invoke this method directly, and many of them don't care about the exclude/include key or schema skipping, I would keep it as it is for easy use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org