deniskuzZ commented on code in PR #4785:
URL: https://github.com/apache/hive/pull/4785#discussion_r1377255204
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:
##########
@@ -565,8 +565,14 @@ public static Map<Integer, List<ExprNodeGenericFuncDesc>>
getFullPartitionSpecs(
CommonTree ast, Table table, Configuration conf, boolean canGroupExprs)
throws SemanticException {
String defaultPartitionName = HiveConf.getVar(conf,
HiveConf.ConfVars.DEFAULTPARTITIONNAME);
Map<String, String> colTypes = new HashMap<>();
- for (FieldSchema fs : table.getPartitionKeys()) {
- colTypes.put(fs.getName().toLowerCase(), fs.getType());
+ if (table.getStorageHandler() != null &&
table.getStorageHandler().alwaysUnpartitioned()) {
+ for (FieldSchema fs : table.getStorageHandler().getPartitionKeys(table))
{
Review Comment:
should we extract population of partition keys
List<FieldSchema> pk = table.getStorageHandler() != null &&
table.getStorageHandler().alwaysUnpartitioned()?table.getStorageHandler().getPartitionKeys(table)
: table.getPartitionKeys()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
