SourabhBadhya commented on code in PR #4785:
URL: https://github.com/apache/hive/pull/4785#discussion_r1379858833
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -1933,6 +1934,16 @@ public List<Partition> dropPartitions(String catName,
String dbName, String tblN
PartitionDropOptions options) throws
TException {
RequestPartsSpec rps = new RequestPartsSpec();
List<DropPartitionsExpr> exprs = new ArrayList<>(partExprs.size());
+ Table table = getTable(catName, dbName, tblName);
+ HiveMetaHook hook = getHook(table);
+ EnvironmentContext context = new EnvironmentContext();
+ if (hook != null) {
+ hook.preDropPartition(table, context, partExprs);
Review Comment:
This is dependent on hook implementation hence skipping based on a boolean
is not the best approach. Thats why passing the skip option through the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
