deniskuzZ commented on code in PR #4785:
URL: https://github.com/apache/hive/pull/4785#discussion_r1377289288
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -5026,7 +5026,8 @@ static boolean isMustPurge(EnvironmentContext envContext,
Table tbl) {
// 3. Either
// 3.1. User has specified PURGE from the commandline, and if not,
// 3.2. User has set the table to auto-purge.
- return ((envContext != null) &&
Boolean.parseBoolean(envContext.getProperties().get("ifPurge")))
+ return (envContext != null && envContext.getProperties() != null
Review Comment:
why is this change?
````
public static boolean parseBoolean(String s) {
return ((s != null) && s.equalsIgnoreCase("true"));
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
