cxzl25 commented on code in PR #4616:
URL: https://github.com/apache/hive/pull/4616#discussion_r1395118836
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -2312,14 +2314,19 @@ private Table convertToTable(MTable mtbl) throws
MetaException {
} else {
tableType = TableType.MANAGED_TABLE.toString();
}
+ } else {
+ if (!tableType.equals(TableType.MANAGED_TABLE.toString()) &&
!tableType.equals(TableType.EXTERNAL_TABLE.toString())) {
Review Comment:
There is a UT here that uses the table type `VIEW`, which causes the test to
fail.
So I'm thinking if this table type might allow other non-enumeration values
to be stored.
https://github.com/apache/hive/blob/3ca97725854df10e7cd67514a3219e996453eab1/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java#L1598
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -2312,14 +2314,19 @@ private Table convertToTable(MTable mtbl) throws
MetaException {
} else {
tableType = TableType.MANAGED_TABLE.toString();
}
+ } else {
+ if (!tableType.equals(TableType.MANAGED_TABLE.toString()) &&
!tableType.equals(TableType.EXTERNAL_TABLE.toString())) {
Review Comment:
There is a UT here that uses the table type `VIEW`, which causes the test to
fail.
So I'm thinking if this table type might allow other non-enumeration values
to be stored.
https://github.com/apache/hive/blob/3ca97725854df10e7cd67514a3219e996453eab1/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java#L1598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
