zhangbutao commented on code in PR #4616:
URL: https://github.com/apache/hive/pull/4616#discussion_r1396734104


##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java:
##########
@@ -1595,7 +1591,7 @@ private Table getTableWithAllParametersSet() throws 
MetaException {
                .setNumBuckets(4)
                .setRetention(30000)
                .setRewriteEnabled(true)
-               .setType("VIEW")
+               .setType("VIRTUAL_VIEW")

Review Comment:
   Looks Interesting. Good catch! We don't actually have the `VIEW` type. But i 
saw it in multiple places. `TestTablesGetExists` also has same misuse, can we 
fix it together? @deniskuzZ WDYT?
   ```suggestion
                  .setType(TableType.VIRTUAL_VIEW.name())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to