cxzl25 commented on code in PR #4616:
URL: https://github.com/apache/hive/pull/4616#discussion_r1396723143
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java:
##########
@@ -262,10 +262,6 @@ public void testCreateGetDeleteTable() throws Exception {
createdTable.unsetId();
Assert.assertEquals("create/get table data", table, createdTable);
- // Check that the directory is created
- Assert.assertTrue("The directory should not be created",
Review Comment:
When the table type is not VIRTUAL_VIEW, the table location will be modified
by `getDnsPath`, so this judgment is meaningless.
https://github.com/apache/hive/blob/8a4f5ce7275842ff4f1cc917c7a2a48dde71bf4c/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L2321-L2331
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java:
##########
@@ -262,10 +262,6 @@ public void testCreateGetDeleteTable() throws Exception {
createdTable.unsetId();
Assert.assertEquals("create/get table data", table, createdTable);
- // Check that the directory is created
- Assert.assertTrue("The directory should not be created",
Review Comment:
When the table type is not `VIRTUAL_VIEW`, the table location will be
modified by `getDnsPath`, so this judgment is meaningless.
https://github.com/apache/hive/blob/8a4f5ce7275842ff4f1cc917c7a2a48dde71bf4c/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L2321-L2331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
