kasakrisz commented on code in PR #4945:
URL: https://github.com/apache/hive/pull/4945#discussion_r1426192921
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7949,7 +7949,15 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
}
} else {
if (tblDesc.isCTAS() && tblDesc.getStorageHandler() != null) {
- tblDesc.setLocation(getCtasOrCMVLocation(tblDesc, viewDesc,
createTableUseSuffix).toString());
+ try {
Review Comment:
This part of the code is in the compiler and it should not depend on Iceberg
or any storage format directly. Hive has `HiveIcebergStorageHandler` interface
to hide storage format customizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
