deniskuzZ commented on code in PR #4945:
URL: https://github.com/apache/hive/pull/4945#discussion_r1428778085
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7949,7 +7949,15 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
}
} else {
if (tblDesc.isCTAS() && tblDesc.getStorageHandler() != null) {
- tblDesc.setLocation(getCtasOrCMVLocation(tblDesc, viewDesc,
createTableUseSuffix).toString());
+ try {
Review Comment:
I agree that compiler code should be `storage format` agnostic, however:
1. SA already has specialized logic for external / ACID / Iceberg
(`isIcebergTable()`) --> requires refactor, we can ignore for now;
2. `HiveStorageHandler` interface is being abused and polluted with many
meaningless methods. `SH#requiresLocation()` - what does it even mean? Could we
please use self-explanatory naming in the interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
