deniskuzZ commented on code in PR #4945:
URL: https://github.com/apache/hive/pull/4945#discussion_r1429995896
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7949,7 +7949,15 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
}
} else {
if (tblDesc.isCTAS() && tblDesc.getStorageHandler() != null) {
- tblDesc.setLocation(getCtasOrCMVLocation(tblDesc, viewDesc,
createTableUseSuffix).toString());
+ try {
+ HiveStorageHandler storageHandler =
+ HiveUtils.getStorageHandler(SessionState.getSessionConf(),
tblDesc.getStorageHandler());
+ if (storageHandler.requiresLocationAtCreateTable()) {
+ tblDesc.setLocation(getCtasOrCMVLocation(tblDesc, viewDesc,
false).toString());
+ }
+ } catch (Exception ex) {
+ LOG.warn("Error while creating HiveStorageHandler instance: {}",
tblDesc.getStorageHandler(), ex);
Review Comment:
is that OK, just to swallow the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
