aturoczy commented on code in PR #4965:
URL: https://github.com/apache/hive/pull/4965#discussion_r1436549212
##########
hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionString.java:
##########
@@ -33,38 +33,30 @@ public FunctionString(Exec e, QueryExecutor queryExecutor) {
public void register(BuiltinFunctions f) {
f.map.put("CONCAT", this::concat);
f.map.put("CHAR", this::char_);
- f.map.put("INSTR", this::instr);
f.map.put("LEN", this::len);
- f.map.put("LENGTH", this::length);
- f.map.put("LOWER", this::lower);
- f.map.put("REPLACE", this::replace);
- f.map.put("SUBSTR", this::substr);
- f.map.put("SUBSTRING", this::substr);
f.map.put("TO_CHAR", this::toChar);
f.map.put("UPPER", this::upper);
-
- f.specMap.put("SUBSTRING", this::substring);
- f.specMap.put("TRIM", this::trim);
Review Comment:
As I see from the test this is required. Please check the test. Put this
back or change the test accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
