amansinha100 commented on code in PR #4965:
URL: https://github.com/apache/hive/pull/4965#discussion_r1444224423
##########
hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionString.java:
##########
@@ -33,38 +33,30 @@ public FunctionString(Exec e, QueryExecutor queryExecutor) {
public void register(BuiltinFunctions f) {
f.map.put("CONCAT", this::concat);
f.map.put("CHAR", this::char_);
- f.map.put("INSTR", this::instr);
f.map.put("LEN", this::len);
- f.map.put("LENGTH", this::length);
- f.map.put("LOWER", this::lower);
- f.map.put("REPLACE", this::replace);
- f.map.put("SUBSTR", this::substr);
- f.map.put("SUBSTRING", this::substr);
f.map.put("TO_CHAR", this::toChar);
f.map.put("UPPER", this::upper);
-
- f.specMap.put("SUBSTRING", this::substring);
- f.specMap.put("TRIM", this::trim);
Review Comment:
@mdayakar I suppose the reason for removing SUBSTRING, TRIM and a few other
functions is that these are builtin functions in Hive, so is HPL/SQL going to
forward the function call to HS2 ? If so, it would be good to add comments in
some common class regarding this. One thing we should verify is if the
HPL/SQL behavior of these functions is the same as what the Hive built-in
function does or is there any small difference. I am curious why these were
implemented in HPL/SQL in the first place since these are SQL standard
functions. Was there additional precondition checks being done or any other
variants that HPL/SQL supported that Hive did not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
