mdayakar commented on code in PR #4965:
URL: https://github.com/apache/hive/pull/4965#discussion_r1441981427
##########
hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionString.java:
##########
@@ -33,38 +33,30 @@ public FunctionString(Exec e, QueryExecutor queryExecutor) {
public void register(BuiltinFunctions f) {
f.map.put("CONCAT", this::concat);
f.map.put("CHAR", this::char_);
- f.map.put("INSTR", this::instr);
f.map.put("LEN", this::len);
- f.map.put("LENGTH", this::length);
- f.map.put("LOWER", this::lower);
- f.map.put("REPLACE", this::replace);
- f.map.put("SUBSTR", this::substr);
- f.map.put("SUBSTRING", this::substr);
f.map.put("TO_CHAR", this::toChar);
f.map.put("UPPER", this::upper);
-
- f.specMap.put("SUBSTRING", this::substring);
- f.specMap.put("TRIM", this::trim);
Review Comment:
@aturoczy Thanks for the review. Test cases are already added for SUBSTRING
and TRIM, also for all functions.
https://github.com/apache/hive/pull/4965/commits/7c0a9f31477453d9974472f487dde4bfff577989#diff-4b45b06ec5de20b8929a80f493ead0990f1208e725d9a403774ecc5f27928227R798-R807
https://github.com/apache/hive/pull/4965/commits/7c0a9f31477453d9974472f487dde4bfff577989#diff-4b45b06ec5de20b8929a80f493ead0990f1208e725d9a403774ecc5f27928227R849-R852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
