zhangbutao commented on code in PR #4995:
URL: https://github.com/apache/hive/pull/4995#discussion_r1449757331
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -181,7 +182,7 @@ private void populateInsertUpdateMap(Map<PartitionInfo,
ColumnStatistics> statsP
e -> e.partitionId).collect(Collectors.toList()
);
- prefix.append("select \"PART_ID\", \"COLUMN_NAME\" from \"PART_COL_STATS\"
WHERE ");
+ prefix.append("select \"PART_ID\", \"COLUMN_NAME\", \"ENGINE\" from
\"PART_COL_STATS\" WHERE ");
Review Comment:
Thanks for explanation!
> there is no guarantee that all of the statsPartInfoMap are for the engine
hive or the same engine,
Is this code snippet only for `insert` statement?
If so, the one `insert` statement is must from the one same `ENGINE` (like
hive or other compute engine), so the `statsPartInfoMap` will have the same
`ENGINE `value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
