dengzhhu653 commented on code in PR #4995:
URL: https://github.com/apache/hive/pull/4995#discussion_r1451872848
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -181,7 +182,7 @@ private void populateInsertUpdateMap(Map<PartitionInfo,
ColumnStatistics> statsP
e -> e.partitionId).collect(Collectors.toList()
);
- prefix.append("select \"PART_ID\", \"COLUMN_NAME\" from \"PART_COL_STATS\"
WHERE ");
+ prefix.append("select \"PART_ID\", \"COLUMN_NAME\", \"ENGINE\" from
\"PART_COL_STATS\" WHERE ");
Review Comment:
@zhangbutao, you need to apply this change to see `populateInsertUpdateMap`
is invoked by the rename operation, there is a batch rename for stats.
In my idea, there is no document that all the stats in `statsPartInfoMap`
must be the same engine, so we cannot simply using the `ENGINE = hive` for all
stats, besides `ENGINE = hive` in the filter is almost the same as in `select
\"ENGINE\"` when there has limited numbers of engines on this partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
