zhangbutao commented on code in PR #4995:
URL: https://github.com/apache/hive/pull/4995#discussion_r1450089524
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -181,7 +182,7 @@ private void populateInsertUpdateMap(Map<PartitionInfo,
ColumnStatistics> statsP
e -> e.partitionId).collect(Collectors.toList()
);
- prefix.append("select \"PART_ID\", \"COLUMN_NAME\" from \"PART_COL_STATS\"
WHERE ");
+ prefix.append("select \"PART_ID\", \"COLUMN_NAME\", \"ENGINE\" from
\"PART_COL_STATS\" WHERE ");
Review Comment:
I did some code debug. Only found that `insert` into statement gone through
this code block(method `populateInsertUpdateMap`), but `alter table rename`
not. Maybe i missed some configuration?
Since `statsPartInfoMap` has the same `ENGINE `value, why not we use this
direct sql to filter the PART_ID based on the `ENGINE` (e.g. `hive`)?
`select "PART_ID", "COLUMN_NAME" from "PART_COL_STATS" WHERE ("PART_ID" in
(141)) and ENGINE = hive`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
