dengzhhu653 commented on code in PR #5206: URL: https://github.com/apache/hive/pull/5206#discussion_r1582003402
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ########## @@ -769,6 +769,28 @@ public List<Partition> run(List<Long> input) throws MetaException { }); } + public List<Partition> getPartitionsViaSqlPs(Table table, GetPartitionsArgs args) throws MetaException { + String catName = table.getCatName(); + String dbName = table.getDbName(); + String tblName = table.getTableName(); + + String sqlFilter = "" + PARTITIONS + ".\"PART_NAME\" like ? "; + String partialName = MetaStoreUtils.makePartNameMatcher(table, args.getPart_vals(), "_%"); Review Comment: have you tested the matcher against other db? such as Postgres, MySQL, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org