dengzhhu653 commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1582005228
##########
standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java:
##########
@@ -648,6 +682,15 @@ static void addManyPartitionsNoException(@NotNull
HMSClient client,
addManyPartitions(client, dbName, tableName, parameters,
arguments, npartitions));
}
+ static void addManyPartitionsNoException(@NotNull HMSClient client,
+ @NotNull String dbName,
+ @NotNull String tableName,
+ @Nullable Map<String, String>
parameters,
+ List<List<String>> values) {
+ throwingSupplierWrapper(() ->
+ addManyPartitions(client, dbName, tableName, parameters, values));
Review Comment:
why not merge these two methods? `addManyPartitionsNoException` and
`addManyPartitions`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
