dengzhhu653 commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1598476963
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -2245,8 +2245,8 @@ public List<Partition> listPartitions(String db_name,
String tbl_name,
public List<Partition> listPartitions(String catName, String db_name, String
tbl_name,
List<String> part_vals, int max_parts)
throws TException {
// TODO should we add capabilities here as well as it returns Partition
objects
- if (db_name == null || tbl_name == null || part_vals == null) {
- throw new MetaException("Database name/Table name/partition values
should not be null");
+ if (db_name == null || tbl_name == null) {
Review Comment:
I think the `part_vals` shouldn't be null according to the comment
indicates: `Get a list of partitions based on a (possibly partial) list of
partition values`.
Another point is what would happen if the new client connects to the old
server which hasn't upgraded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
