deniskuzZ commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1699994287
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1901,10 +1901,12 @@ public boolean
canUseTruncate(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
private boolean hasUndergonePartitionEvolution(Table table) {
// If it is a table which has undergone partition evolution, return true.
+ // if a table has undergone partition evolution, the current spec is not
necessary the latest which can happen
Review Comment:
just keep the part about the current spec, cause it's valid not only for
partition evolution case
`the current spec is not necessary the latest which can happen when
partition spec was changed to one of table's past specs.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
