deniskuzZ commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1699997122
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1923,15 +1923,20 @@ public Optional<ErrorMsg> isEligibleForCompaction(
@Override
public List<Partition>
getPartitions(org.apache.hadoop.hive.ql.metadata.Table table,
- Map<String, String> partitionSpec) throws SemanticException {
- return getPartitionNames(table, partitionSpec).stream()
+ Map<String, String> partitionSpec, boolean latestSpecOnly) throws
SemanticException {
+ return getPartitionNames(table, partitionSpec, latestSpecOnly).stream()
.map(partName -> {
Map<String, String> partSpecMap = Maps.newLinkedHashMap();
Warehouse.makeSpecFromName(partSpecMap, new Path(partName), null);
return new DummyPartition(table, partName, partSpecMap);
}).collect(Collectors.toList());
}
+ public boolean isPartitioned(org.apache.hadoop.hive.ql.metadata.Table
hmsTable) {
Review Comment:
wouldn't it be better to move this into `IcebergTableUtil`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
