deniskuzZ commented on code in PR #5870:
URL: https://github.com/apache/hive/pull/5870#discussion_r2149481104
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -431,7 +432,8 @@ public void setThreadFactory(ThreadFactory threadFactory) {
processor = new ThriftHiveMetastore.Processor<>(handler);
LOG.info("Starting DB backed MetaStore Server with generic processor");
boolean jwt = MetastoreConf.getVar(conf,
ConfVars.THRIFT_METASTORE_AUTHENTICATION).equalsIgnoreCase("jwt");
- ServletSecurity security = new ServletSecurity(conf, jwt);
+ AuthType authType = jwt ? AuthType.JWT : AuthType.SIMPLE;
Review Comment:
why do we need these hacks? can we drop the jwt var completely?
I think we should replace `ICEBERG_CATALOG_SERVLET_AUTH` &
`PROPERTIES_SERVLET_AUTH`
with
`METASTORE_REST_CATALOG_AUTH("metastore.rest-catalog.authentication"` since
these servlets are deployed within the same servlet container.
````
String authType = MetastoreConf.getVar(configuration,
ConfVars.METASTORE_REST_CATALOG_AUTH);
ServletSecurity security = new
ServletSecurity(AuthType.fromString(authType), configuration);
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
