deniskuzZ commented on code in PR #5870:
URL: https://github.com/apache/hive/pull/5870#discussion_r2152234056
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -431,7 +432,8 @@ public void setThreadFactory(ThreadFactory threadFactory) {
processor = new ThriftHiveMetastore.Processor<>(handler);
LOG.info("Starting DB backed MetaStore Server with generic processor");
boolean jwt = MetastoreConf.getVar(conf,
ConfVars.THRIFT_METASTORE_AUTHENTICATION).equalsIgnoreCase("jwt");
- ServletSecurity security = new ServletSecurity(conf, jwt);
+ AuthType authType = jwt ? AuthType.JWT : AuthType.SIMPLE;
Review Comment:
ok, how about
````
String authType = MetastoreConf.getVar(configuration,
ConfVars.THRIFT_METASTORE_AUTHENTICATION);
ServletSecurity security = new ServletSecurity(
AuthType.JWT.name().equalsIgnoreCase(authType) ? AuthType.JWT :
AuthType.SIMPLE,
configuration);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
