okumin commented on code in PR #5909: URL: https://github.com/apache/hive/pull/5909#discussion_r2174259073
########## cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: ########## @@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti StringBuilder qsb = new StringBuilder(); while ((line = r.readLine()) != null) { + // Skipping the proto tables location. + if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue; Review Comment: How about simply replacing the variables with the full path on the test filesystem? I would say the current one has no side effect since CliDriver is used in only tests. When we drop it, we have to implement the same logic on Beeline. It is likely hacky or troublesome in the worst case to interrupt with the parser's behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org