okumin commented on code in PR #5909: URL: https://github.com/apache/hive/pull/5909#discussion_r2175023151
########## cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: ########## @@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti StringBuilder qsb = new StringBuilder(); while ((line = r.readLine()) != null) { + // Skipping the proto tables location. + if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue; Review Comment: So, how about using `processLine` directly or a suitable method? `cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java` is not test code, but production code, although it's deprecated. It's better to avoid adding contextual branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org