Aggarwal-Raghav commented on code in PR #5909: URL: https://github.com/apache/hive/pull/5909#discussion_r2174927238
########## cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: ########## @@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti StringBuilder qsb = new StringBuilder(); while ((line = r.readLine()) != null) { + // Skipping the proto tables location. + if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue; Review Comment: @okumin, with the above pseudocode, it will end up reading the schema file + writing modified schema file (QTestSysDbHandler.java) and then again reading a modified schema file (CliDriver.java) **for each q file using sysdb**. I'm not inline with this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org