ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2179368269
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,20 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache = new
HiveMetaStoreClientWithLocalCache(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient = new SessionHiveMetaStoreClient(conf,
clientWithLocalCache);
+ IMetaStoreClient clientWithHook = new
HookEnabledMetaStoreClientProxy(conf, hookLoader, sessionLevelClient);
Review Comment:
I have checked that this patch calls `preCreateTable()` using the test
`TestHiveIcebergStorageHandlerNoScan#testCreateTemporaryTable`, as `Hive.java`
wraps `SessionHiveMetaStoreClient` with `HookEnabledMetaStoreClientProxy`. I
may have misunderstood your point, so I'm sorry but could you elaborate on the
requested changes again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
