ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2179425471
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,20 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache = new
HiveMetaStoreClientWithLocalCache(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient = new SessionHiveMetaStoreClient(conf,
clientWithLocalCache);
+ IMetaStoreClient clientWithHook = new
HookEnabledMetaStoreClientProxy(conf, hookLoader, sessionLevelClient);
Review Comment:
Yes, that will call `createTempTable(tbl)` in `SessionHiveMetaStoreClient`,
but before reaching here, we meet
`HookEnabledMetaStoreClientProxy#createTable`, which calls `preCreateTable()`.
I attached the stack trace of the previously mentioned test for your
understanding.
```
Caused by: java.lang.UnsupportedOperationException: Creation of temporary
iceberg tables is not supported.
at
org.apache.iceberg.mr.hive.HiveIcebergMetaHook.preCreateTable(HiveIcebergMetaHook.java:227)
~[classes/:?]
at
org.apache.hadoop.hive.metastore.client.HookEnabledMetaStoreClientProxy.createTable(HookEnabledMetaStoreClientProxy.java:111)
~[hive-exec-4.1.0-SNAPSHOT.jar:4.1.0-SNAPSHOT]
at jdk.internal.reflect.GeneratedMethodAccessor91.invoke(Unknown Source)
~[?:?]
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:?]
at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at
org.apache.hadoop.hive.metastore.client.SynchronizedMetaStoreClientProxy$SynchronizedHandler.invoke(SynchronizedMetaStoreClientProxy.java:68)
~[hive-exec-4.1.0-SNAPSHOT.jar:4.1.0-SNAPSHOT]
at jdk.proxy2/jdk.proxy2.$Proxy39.createTable(Unknown Source) ~[?:?]
at
org.apache.hadoop.hive.metastore.client.BaseMetaStoreClientProxy.createTable(BaseMetaStoreClientProxy.java:452)
~[hive-exec-4.1.0-SNAPSHOT.jar:4.1.0-SNAPSHOT]
at jdk.internal.reflect.GeneratedMethodAccessor91.invoke(Unknown Source)
~[?:?]
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:?]
at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at
org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.invoke(RetryingMetaStoreClient.java:213)
~[hive-exec-4.1.0-SNAPSHOT.jar:4.1.0-SNAPSHOT]
at jdk.proxy2/jdk.proxy2.$Proxy39.createTable(Unknown Source) ~[?:?]
at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:1429)
~[hive-exec-4.1.0-SNAPSHOT.jar:4.1.0-SNAPSHOT]
... 69 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
