deniskuzZ commented on code in PR #5929:
URL: https://github.com/apache/hive/pull/5929#discussion_r2185160643
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -11448,36 +11454,34 @@ public List<WriteEventInfo> getAllWriteEventInfo(long
txnId, String dbName, Stri
return writeEventInfoList;
}
- private void prepareQuotes() throws SQLException {
- String s = dbType.getPrepareTxnStmt();
- if (s != null) {
- assert pm.currentTransaction().isActive();
- JDOConnection jdoConn = pm.getDataStoreConnection();
- try (Statement statement = ((Connection)
jdoConn.getNativeConnection()).createStatement()) {
- statement.execute(s);
- } finally {
- jdoConn.close();
- }
- }
- }
-
- private void lockNotificationSequenceForUpdate() throws MetaException {
+ private void lockForUpdate(String tableName, String column, String rowFilter)
Review Comment:
Wouldn't it be better with `Optional`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
