deniskuzZ commented on code in PR #5929:
URL: https://github.com/apache/hive/pull/5929#discussion_r2185168242


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -9517,6 +9517,9 @@ public Map<String, String> 
updateTableColumnStatistics(ColumnStatistics colStats
       // So let's not use them anywhere unless absolutely necessary.
       String catName = statsDesc.isSetCatName() ? statsDesc.getCatName() : 
getDefaultCatalog(conf);
       MTable mTable = ensureGetMTable(catName, statsDesc.getDbName(), 
statsDesc.getTableName());
+      lockForUpdate("TBLS", "TBL_ID", "\"TBL_ID\" = " + mTable.getId());

Review Comment:
   Why do we need a lock on "TBLS" when updating stats? Why not lock on 
`COLUMNS_V2.CD_ID`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to