deniskuzZ commented on code in PR #5929:
URL: https://github.com/apache/hive/pull/5929#discussion_r2185168242
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -9517,6 +9517,9 @@ public Map<String, String>
updateTableColumnStatistics(ColumnStatistics colStats
// So let's not use them anywhere unless absolutely necessary.
String catName = statsDesc.isSetCatName() ? statsDesc.getCatName() :
getDefaultCatalog(conf);
MTable mTable = ensureGetMTable(catName, statsDesc.getDbName(),
statsDesc.getTableName());
+ lockForUpdate("TBLS", "TBL_ID", "\"TBL_ID\" = " + mTable.getId());
Review Comment:
Why do we need a lock on "TBLS" when updating stats? Why not lock on
`TAB_COL_STATS`?
can we check the result of `oldt.setParameters(newParams)` and retry when
false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
