zratkai commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2185658279
##########
beeline/src/java/org/apache/hive/beeline/Commands.java:
##########
@@ -291,7 +291,7 @@ public boolean dropall(String line) {
return beeLine.error(beeLine.loc("no-current-connection"));
}
try {
- if
(!(beeLine.getConsoleReader().readLine(beeLine.loc("really-drop-all")).equals("y")))
{
+ if
(!(beeLine.getLineReader().readLine(beeLine.loc("really-drop-all")).equals("y")))
{
Review Comment:
Can we add it as a private static final field?
##########
beeline/src/java/org/apache/hive/beeline/BeeLine.java:
##########
@@ -1147,7 +1154,15 @@ public int begin(String[] args, InputStream inputStream,
boolean keepHistory) th
} catch (Exception e) {
// ignore
}
- return execute(reader, false);
+ return startListening();
Review Comment:
Why not calling execute(lineReader, false); ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
