abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2207287857
##########
beeline/src/java/org/apache/hive/beeline/BeeLine.java:
##########
@@ -938,8 +945,8 @@ private boolean connectUsingArgs(BeelineParser
beelineParser, CommandLine cl) {
String propertyFile = cl.getOptionValue("property-file");
if (propertyFile != null) {
try {
- this.consoleReader = new ConsoleReader();
- } catch (IOException e) {
+ this.lineReader = LineReaderBuilder.builder().build();
+ } catch (IOError e) {
handleException(e);
Review Comment:
```
this.lineReader = LineReaderBuilder.builder().build();
```
doesn't throw a checked exception at all, will remove the whole try/catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
