abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2186888644
##########
beeline/src/java/org/apache/hive/beeline/Commands.java:
##########
@@ -291,7 +291,7 @@ public boolean dropall(String line) {
return beeLine.error(beeLine.loc("no-current-connection"));
}
try {
- if
(!(beeLine.getConsoleReader().readLine(beeLine.loc("really-drop-all")).equals("y")))
{
+ if
(!(beeLine.getLineReader().readLine(beeLine.loc("really-drop-all")).equals("y")))
{
Review Comment:
hm, I haven't touched constants with this PR, but as it's already huge, this
can also be taken care of
btw, e.g. "really-drop-all" and all other strings used in beeline.loc are
used only once in the Commands class, does it make sense to refactor all of
them to contants @zratkai ? there are around 40 of them, I mean, we would end
up having 40 private static final in Commands that are used only once and used
only in this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
