ngsg commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-3039343156
I left this comment mainly as a note for future work. Regarding the naming of the client classes, since we already have `BaseMetaStoreClient`, we should find a different name for `BaseMetaStoreClientProxy` if we decide to remove Proxy from the class names. Maybe we could reuse its former name, `NormalizedMetaStoreClient`, or consider something like `Unifying` or `Linearizing`. I don't have a clear idea yet, but we can revisit this later. I also found some unused imports in `BaseMetaStoreClientProxy`, which shouldn’t take much of our time. Let me upload a quick minor commit for it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
