ngsg commented on code in PR #5771: URL: https://github.com/apache/hive/pull/5771#discussion_r2187446575
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ########## @@ -18,92 +18,24 @@ package org.apache.hadoop.hive.metastore; Review Comment: I think it would be better to organize all client-related classes under the `client` package, but I’m not sure about moving existing classes that are already publicly exposed. (e.g., Spark instantiates it to check connectivity.) If you think it's acceptable, I’ll move the existing client-related classes, including `HiveMetaStoreClient`, `SessionHiveMetaStoreClient`, and others, into the two client packages (`o.a.h.h.ql.metadata.client` and `o.a.h.h.metastore.client`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
