ngsg commented on code in PR #5771: URL: https://github.com/apache/hive/pull/5771#discussion_r2187458438
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ########## @@ -18,92 +18,24 @@ package org.apache.hadoop.hive.metastore; Review Comment: Ah, I see. I hadn’t checked the edited version. In my opinion, this could be included in client, as it truly relates to the MetaStore client. Also, since `metastore-server/pom.xml` will depend on `hive-standalone-metastore-client`, we can keep the existing test code in `hive-standalone-metastore-server` that uses `HiveMetaStoreClient`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
