deniskuzZ commented on code in PR #5934:
URL: https://github.com/apache/hive/pull/5934#discussion_r2189182854
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,8 +70,8 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
- new ConcurrentHashMap<>();
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
> @deniskuzZ
>
> > i reverted to static as it was a global cache before
>
> So, if I do this, is it possible that it will cause splitGrouper to
produce incorrect calculation results? Because no one updates it.
>
> ```
> alter table xxx drop partition([pt=11);
> alter table xxx add partition([pt=11) location '/p1';
> alter table xxx drop partition([pt=11);
> alter table xxx add partition([pt=11) location '/p2';
> alter table xxx drop partition([pt=11);
> alter table xxx add partition([pt=11) location '/p1';
> ```
i removed the global cache as i don't see how it's even being used. However,
it wouldn't cause an issue since it just contains normalized path mapping and
doesn't cache the `PartitionDesc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
