BsoBird commented on code in PR #5934:
URL: https://github.com/apache/hive/pull/5934#discussion_r2189567183
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,8 +70,8 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
- new ConcurrentHashMap<>();
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
> please take a look at https://github.com/apache/hive/pull/5935/files, it
has some extra checkstyle fixes. If that looks OK, please re-apply here. TBH, I
have no idea why in a world someone came up with this `Map<Map<>,Map<>>` data
structure for a normalized path map.
I will update it later.
I guess the previous author added PartitionDesc to the map-key to maintain
the partition information after the user modifies the partition.
For example, after modifying the partition, the user might have changed the
path information of the partition. In the original structure, we could capture
this change.
However, using a map to store the data is quite strange. Maybe he just
wanted to use a Tuple2<Path, PartitionDesc>?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
