deniskuzZ commented on code in PR #5934:
URL: https://github.com/apache/hive/pull/5934#discussion_r2190553680
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,8 +70,8 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
- new ConcurrentHashMap<>();
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
@BsoBird, thanks for the details, it helped a lot. i managed to create a
test that initializes the cache from `SplitGroper`.
Note, I struggled to create an iceberg table backed by HadoopCatalog
````
set iceberg.catalog.ice01.type=hadoop;
set iceberg.catalog.ice01.warehouse=/tmp;
CREATE EXTERNAL TABLE orders (orderid INT, quantity INT, itemid INT, tradets
TIMESTAMP)
PARTITIONED BY (p1 STRING, p2 STRING)
STORED BY ICEBERG STORED AS ORC
LOCATION '/tmp/ice01/orders'
TBLPROPERTIES('format-version'='2', 'iceberg.catalog'='ice01');
````
Caused by: java.lang.IllegalArgumentException: Cannot set a custom location
for a path-based table. Expected /tmp/default/orders but got
file:/tmp/ice01/orders
````
CREATE EXTERNAL TABLE orders (orderid INT, quantity INT, itemid INT, tradets
TIMESTAMP)
PARTITIONED BY (p1 STRING, p2 STRING)
STORED BY ICEBERG STORED AS ORC
LOCATION '/tmp/ice01/orders'
TBLPROPERTIES('format-version'='2', 'iceberg.catalog'='ice01');
````
Caused by: java.lang.IllegalArgumentException: Table location not set
Wonder how did were you able to create one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
