BsoBird commented on code in PR #5934:
URL: https://github.com/apache/hive/pull/5934#discussion_r2191868462
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,8 +70,8 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
- new ConcurrentHashMap<>();
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
> !!! Currently, this cache isn't useful for Iceberg tables because
SplitGrouper doesn't receive any partition information. The dir path always
points to the table directory, and the same applies to the keys in
pathToPartitionInfo
@deniskuzZ
You mean, even if we keep PartitionDesc, we shouldn't encounter a deadlock?
That's very strange. We did experience a deadlock when reading Iceberg
tables before. We never encountered this issue when reading regular ORC tables.
However, at that time we were using HIVE 3.1.3 to read ICEBERG tables. Has
this issue disappeared in HIVE4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
