abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2207620454
##########
beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java:
##########
@@ -38,11 +41,11 @@ class TableNameCompletor implements Completer {
}
@Override
- public int complete(String buf, int pos, List cand) {
- if (beeLine.getDatabaseConnection() == null) {
- return -1;
+ public void complete(LineReader reader, ParsedLine line, List<Candidate>
candidates) {
Review Comment:
this implements Jline3's completer, which changed its signature, we cannot
do anything else than following
fortunately beeline doesn't expose this return value, as it's part of jline
internals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
